search

gohugoio / hugoThemesSiteBuilder

The source for https://themes.gohugo.io
https://themes.gohugo.io
Apache License 2.0
214 stars 192 forks source link

Themes updated inconsistently #416

Closed leoheitmannruiz closed 7 months ago

leoheitmannruiz commented 7 months ago

It seems the Updated metadata displayed at themes.gohugo.io, for a few themes that have releases on GitHub, is the date of the latest release, not the latest commit, as is the case for most themes.

It seems to correlate with the way they are found in cmd/hugothemesitebuilder/build/go.mod:

However, for other themes, which have releases on GitHub, the date of the latest commit is displayed at themes.gohugo.io:

I suspect the first case also leads to the themes not being updated at themes.gohugo.io, as in the case of docsy: they have added a demosite several days ago, but the link is not displayed.

bep commented 7 months ago

latest release, not the latest commit, as is the case for most themes.

It picks either:

  1. The latest release date (semver tag)
  2. The latest commit if theme has no releases.

This is backed by Go Modules (and not some home made logic of this theme)

leoheitmannruiz commented 7 months ago

Thanks! Glad to know what's going on there :)

I would prefer if the date was always the date of the last commit, though I suspect the complexity is not worth it.

Feel free to close this issue.

bep commented 7 months ago

I would prefer if the date was always the date of the last commit, though I suspect the complexity is not worth it.

Note that the date represents the commit of the theme that we used (e.g. README content etc.), so I think it makes perfectly sense.