search

gohugoio / hugoThemesSiteBuilder

The source for https://themes.gohugo.io
https://themes.gohugo.io
Apache License 2.0
221 stars 198 forks source link

Add theme Landing Page Builder #423

Open gcushen opened 8 months ago

gcushen commented 8 months ago

Add theme Landing Page Builder

netlify[bot] commented 8 months ago

Deploy Preview for hugothemes failed.

Name Link
Latest commit 5f77952cd564d2aa533de39250b2bb134ca5247a
Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/664679d09673660008c19806
leoheitmannruiz commented 8 months ago

Hey!

The path to the image in your README.md is relative, which means it won't be displayed at themes.gohugo.io.

Please consider making the path absolute :)

leoheitmannruiz commented 8 months ago

You might also want to so at https://github.com/HugoBlox/theme-academic-cv.

gcushen commented 7 months ago

@hugo-sid we've updated the Readme with absolute image path as requested. Hope it's all good to proceed with merge now? Thanks :)

hugo-sid commented 6 months ago

We have clearly stated in the README that:

Themes with READMEs set up as marketing campaigns for other products will not be accepted.

Your theme seems to be doing exactly this.

We will not be able to add your theme in this case.

Thank you for your understanding.

gcushen commented 6 months ago

@bep @hugo-sid Please clarify why you are banning open source projects from being listed on the Hugo Themes site?

The purpose of the GitHub Readme is to market and promote the open source project... It's common for Hugo Themes on Hugo Themes Site to allow for donations/sponsorships, in fact the Hugo repo itself offers the ability to sponsor Bep - what is your issue with this? Other themes you have added also allow for donations, so why are you singling this theme out as not allowed that? What other marketing campaign are you referring to?

jmooring commented 6 months ago

@hugo-sid

Thank you for volunteering to manage this project's issue and PR queue. It's a thankless job, and I appreciate your efforts. Serving as a gatekeeper is never easy, requiring thick skin, particularly when you are performing these duties without compensation.

Having said that, in this case I would respectfully ask you to reconsider your assessment. I think the primary goal of this aspect of the acceptance criteria is to prevent "bait-and-switch" behavior. Although the Landing Page Builder README could benefit from some clarification[^1], it is not a bait-and-switch proposition.

Thanks in advance for your consideration.

[^1]: For example, "Build your Landing Pages with Blocks" makes sense... it tells me about this project. In contrast, "Build your Landing Pages with Hugo Blox" conflates two projects.

hugo-sid commented 5 months ago

@hugo-sid Please clarify why you are banning open source projects from being listed on the Hugo Themes site?

Thanks for your understanding. Let me clarify.

The purpose of the GitHub Readme is to market and promote the open source project... It's common for Hugo Themes on Hugo Themes Site to allow for donations/sponsorships, in fact the Hugo repo itself offers the ability to sponsor Bep - what is your issue with this? Other themes you have added also allow for donations, so why are you singling this theme out as not allowed that?

I never said that donations/sponsorships links are creating problem. They are perfectly fine.

What other marketing campaign are you referring to?

The readme of the theme (& other parts such as repository description) has several links to https://hugoblox.com which is a website offering paid Hugo themes.

I see that there are free themes & paid themes available on that website. In the past, one such website/organisation (which offered paid & free themes) was disallowed to list their free themes on the themes.gohugo.io site.

hugo-sid commented 5 months ago

@hugo-sid

Thank you for volunteering to manage this project's issue and PR queue. It's a thankless job, and I appreciate your efforts. Serving as a gatekeeper is never easy, requiring thick skin, particularly when you are performing these duties without compensation.

@jmooring, thank you for your kind words & appreciation of my efforts.

Having said that, in this case I would respectfully ask you to reconsider your assessment. I think the primary goal of this aspect of the acceptance criteria is to prevent "bait-and-switch" behavior. Although the Landing Page Builder README could benefit from some clarification1, it is not a bait-and-switch proposition.

Thanks in advance for your consideration.

Footnotes

  1. For example, "Build your Landing Pages with Blocks" makes sense... it tells me about this project. In contrast, "Build your Landing Pages with Hugo Blox" conflates two projects. ↩

Thank you for your valuable inputs. Indeed I am reconsidering my assessment. I request you to kindly go through my last comment, and let me know your thoughts.

bep commented 5 months ago

@bep @hugo-sid Please clarify why you are banning open source projects from being listed on the Hugo Themes site?

That was not the intention, and to me this theme addition looks good.

The sentence in question was added to the README to target themes that acted as promotional banners for commercial theme sites.

Financing the theme development work via GitHub sponsors is a different story.

hugo-sid commented 5 months ago

Thanks for your inputs @bep.

to me this theme addition looks good.

There is no doubt about that. This is a great theme.

The sentence in question was added to the README to target themes that acted as promotional banners for commercial theme sites.

IMHO, this theme has several links to commercial theme site https://hugoblox.com.

Perhaps "promotional banners" is a grey area we need to sort out. It would be great, if we can clearly define what constitutes violation of that rule (or what is considered as promotional banner).

Are we saying that:

I came across a theme https://github.com/zerostaticthemes/hugo-whisper-theme?tab=readme-ov-file#credits (presently listed on themes.gohugo.io), which has many links to commercial theme sites. What do you have to say in this regard?

Pardon me if I have overlooked some things or missed out something which may seem obvious. Please don't be under the impression that I am adamant not to include this theme. I am just trying to seek more clarity regarding this rule. I believe this will help ensure compliance and avoid any future misunderstandings (whenever such cases come up). Thank you for your patience and assistance.

bep commented 5 months ago

IMHO, this theme has several links to commercial theme site https://hugoblox.com.

OK, I didn't see that. Then I (we) need to think about this some more. I will get back after some thinking, lets just leave this PR/issue open for now.

gcushen commented 5 months ago

commercial theme site

This is the website for the open source project here: https://github.com/HugoBlox/hugo-blox-builder

The website enables users who value the templates to donate via GitHub Sponsors or LemonSqueezey to support further development of the open source project and be rewarded with some perks for doing so, just like if I sponsor Bep, Bep may kindly send some Hugo stickers.

So if donations are considered 'commercial' and disallowed, I guess we should also remove all the other themes on here which have a link to sponsor the creator/maintainer so that each theme is assessed fairly and there's no bias?