search

gohugoio / hugoThemesSiteBuilder

The source for https://themes.gohugo.io
https://themes.gohugo.io
Apache License 2.0
214 stars 192 forks source link

add theme ardeidae #429

Closed LuisSousaRego closed 3 months ago

netlify[bot] commented 6 months ago

Deploy Preview for hugothemes ready!

Name Link
Latest commit 48b7e35f482926799e06fcb9060e303f850b2c2a
Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/65ef27b4dbf62f0008c616f4
Deploy Preview https://deploy-preview-429--hugothemes.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hugo-sid commented 6 months ago

Thanks for adding Ardeidae theme.

The link to demo site on your readme shows this:

image

This doesn't match the screenshot image(s) that you have provided.

Can you please fix the demo website?

leoheitmannruiz commented 6 months ago

The demo site looks fine on my end.

Edit: Ups, sorry. In Firefox the site looks fine, but not in Chromium and Safari.

leoheitmannruiz commented 6 months ago

I believe this is due to the fact that the hrefs of the stylesheets use http, so when you're on the https version of the site they aren't loaded (in Chromium and Safari, Firefox doesn't seem to care).

LuisSousaRego commented 5 months ago

Thanks for noticing! Should be fixed now

leoheitmannruiz commented 5 months ago

Out of curiosity: why use absolute links instead of relative ones?

Edit: Not just for the CSS, but for everything than may be relative.

hugo-sid commented 5 months ago

@LuisSousaRego thanks for fixing the demo website.

Can you could include some instructions on how to use your theme in the README file?

LuisSousaRego commented 5 months ago

@LuisSousaRego thanks for fixing the demo website.

Can you could include some instructions on how to use your theme in the README file?

sure! done

LuisSousaRego commented 5 months ago

Out of curiosity: why use absolute links instead of relative ones?

Edit: Not just for the CSS, but for everything than may be relative.

good question, I don't remember why I used abs urls in the first place, but now that you mentioned it I switched to using rel urls