search

gohugoio / hugoThemesSiteBuilder

The source for https://themes.gohugo.io
https://themes.gohugo.io
Apache License 2.0
210 stars 190 forks source link

Add theme freshpink #431

Closed ElecBrandy closed 5 months ago

ElecBrandy commented 5 months ago

Introducing FreshPink, a Hugo blog theme designed specifically for developers embarking on creating or enhancing their development blog. With an emphasis on simplicity and functionality, FreshPink offers a clean and straightforward design, complemented by a vibrant fresh pink color scheme, and packed with features that cater to the unique needs of developer blogs.

netlify[bot] commented 5 months ago

Deploy Preview for hugothemes ready!

Name Link
Latest commit 36b6b96ed69a03c1c9020966739e9805c95a156a
Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/65f34a3d407d7100087caa34
Deploy Preview https://deploy-preview-431--hugothemes.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hugo-sid commented 5 months ago

Thanks for adding FreshPink theme.

Could you please resolve the following issues?

  1. The LICENSE in your repository starts with:

    MIT License

Copyright (c) [year] [fullname]

    Could you please include year and name in LICENSE ?

  2. You have a demo website (https://elecbrandy.github.io/freshpink/). Could you please mention/put it somewhere in the README.md ?
  3. Could you please update the year in footer from 2023 to 2024 here ?
leoheitmannruiz commented 5 months ago

Also, please use absolute paths for the images in the README: https://github.com/gohugoio/hugoThemesSiteBuilder?tab=readme-ov-file#use-absolute-paths-for-images

ElecBrandy commented 5 months ago

Thank you! We've fixed the things you mentioned! Could you please confirm?

leoheitmannruiz commented 5 months ago

The paths to the images in the README are clearly wrong, as the images are not displayed.

For instance, the correct link for tn.png is https://raw.githubusercontent.com/ElecBrandy/freshpink/main/images/tn.png (you're missing the branch).

ElecBrandy commented 5 months ago

sry..! i fixed it now!

ElecBrandy commented 5 months ago

Excuse me, I was wondering when the theme I created could be uploaded to https://themes.gohugo.io/ as I was wondering how often it would be updated :)

hugo-sid commented 5 months ago

Also, please use absolute paths for the images in the README: https://github.com/gohugoio/hugoThemesSiteBuilder?tab=readme-ov-file#use-absolute-paths-for-images

@leoheitmannruiz thanks for the observation & help.