search

gohugoio / hugoThemesSiteBuilder

The source for https://themes.gohugo.io
https://themes.gohugo.io
Apache License 2.0
210 stars 190 forks source link

Update theme hugo-theme-gallery #435

Closed nicokaiser closed 4 months ago

netlify[bot] commented 5 months ago

Deploy Preview for hugothemes ready!

Name Link
Latest commit e6e5073d5d26d68dd348d960f52530ca06a5e2ab
Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/65fd60422fd03a0008028f37
Deploy Preview https://deploy-preview-435--hugothemes.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hugo-sid commented 5 months ago

@nicokaiser could you please:

nicokaiser commented 5 months ago

The Download link seems to be wrong. I'll try to remove the version from the URL.

hugo-sid commented 5 months ago

The Download link seems to be wrong.

You are right. The download button on this page leads to a 404. Related: https://github.com/gohugoio/hugoThemesSiteBuilder/pull/428.

I'll try to remove the version from the URL.

Then there are no changes in this PR, I guess.

hugo-sid commented 5 months ago

@nicokaiser, I guess your motivation behind this PR was to update the theme metadata shown on themes website (https://themes.gohugo.io/).

A scheduled GitHub action responsible for updating theme metadata was failing from past few days. This caused the theme information/metadata displayed on themes website to be outdated.

I have fixed the GitHub action a few minutes ago. The themes website is now updated with the latest metadata.

Feel free to close this PR if that solved your issue.

nicokaiser commented 5 months ago

@hugo-sid Yes, exactly! Maybe it was a combination of "I did not propery update my theme.toml" and the failing GitHub action, so I though I'd need to add the version to the theme URL.

As of now, the website shows a very old version of the theme's README: https://themes.gohugo.io/themes/hugo-theme-gallery/ vs. https://github.com/nicokaiser/hugo-theme-gallery/

The website states "Updated: 2023-11-22", so seems to ignore newer versions (current version is 4.x), that's why I thought I need to use the Hugo Module syntax for the theme URL...

nicokaiser commented 5 months ago

@hugo-sid The cmd/hugothemesitebuilder/build/go.mod file seems to be outdated for the github.com/nicokaiser/hugo-theme-gallery module. Instead of v0.0.0-* it should use v4.x. How can I update the theme version?

hugo-sid commented 5 months ago

@nicokaiser, I am trying to address the issue that you have mentioned.

Related PRs: #439, #440

hugo-sid commented 4 months ago

@nicokaiser, I have created a new PR https://github.com/gohugoio/hugoThemesSiteBuilder/pull/440, which updates your theme.

Please check the Netlify deploy preview link there.

Feel free to let me know if there are any issues.

Closing this one for now.