gohugoio / hugoThemesSiteBuilder

The source for https://themes.gohugo.io
https://themes.gohugo.io
Apache License 2.0
210 stars 190 forks source link

Add back the zen theme. #453

Closed frjo closed 4 months ago

frjo commented 4 months ago

Attempting to add back the Zen theme. Related PRs: #439, #440, #435

netlify[bot] commented 4 months ago

Deploy Preview for hugothemes ready!

Name Link
Latest commit ae0e5da7ac127494b99238cdb3de7ccd4408e4db
Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/662b555cd172e500089e90cb
Deploy Preview https://deploy-preview-453--hugothemes.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

frjo commented 4 months ago

If I add my theme with github.com/frjo/hugo-theme-zen (no version part) the preview does not include the Zen theme at all.

If I add my theme with github.com/frjo/hugo-theme-zen/v3 (with version part) the preview displays the Zen theme in order but with an incorrect path for the download button. It sets the download path to include the version part making the download link end in a 404.

There seems to be a bug with setting html_url for themes with a version. I suspect it works for some theme due to the correct html_url being cached.