search

gohugoio / hugoThemesSiteBuilder

The source for https://themes.gohugo.io
https://themes.gohugo.io
Apache License 2.0
210 stars 190 forks source link

Issue with specifying version for themes (Go modules) in `themes.txt` #454

Closed hugo-sid closed 3 months ago

hugo-sid commented 4 months ago

If I add my theme with github.com/frjo/hugo-theme-zen (no version part) the preview does not include the Zen theme at all.

If I add my theme with github.com/frjo/hugo-theme-zen/v3 (with version part) the preview displays the Zen theme in order but with an incorrect path for the download button. It sets the download path to include the version part making the download link end in a 404.

There seems to be a bug with setting html_url for themes with a version. I suspect it works for some theme due to the correct html_url being cached.

Originally posted by @frjo in https://github.com/gohugoio/hugoThemesSiteBuilder/issues/453#issuecomment-2074554583

hugo-sid commented 4 months ago

PR #435 is also related to this issue.

/cc: @bep .

bep commented 4 months ago

Yea, I see the problem, I will fix it.

frjo commented 4 months ago

Fixed now as far as I can see, thanks!

https://github.com/gohugoio/hugoThemesSiteBuilder/pull/455

hugo-sid commented 3 months ago

Yea, I see the problem, I will fix it.

Thanks for the fix.