Colinmacdonald/17 render url

goinstant / chat

The GoInstant Chat widget provides real-time chat to users inside a room of your application.. This repo will no longer be updated. GoInstant will be discontinued as of August 31, 2014. Read our blog for more details.

https://goinstant.com

BSD 3-Clause "New" or "Revised" License

16 stars 10 forks source link

Colinmacdonald/17 render url #28

Closed colinmacdonald closed 10 years ago

colinmacdonald commented 10 years ago

Closes #6 Closes #20 Closes #17

Adds a default chat example
Fixes avatars to fit the default 25x25 style.
Adds link and img support.
Refactors view and tests
Fixes IE8 bugs:
- removes the use of getElementsByClass (unsupported in IE8)
- adds type="button" to prevent enter input keydowns clicking the button and causing duplicate messages in IE8

nealstewart commented 10 years ago

You're still sending and storing the entire user object in every chat message.

I would suggest accessing and sending only the information that is relevant to the chat display, rather than all of the data stored on every user.

This is not required in this PR, but would be a good change.

colinmacdonald commented 10 years ago

@tmyrden @nealstewart made the fixes to your comments.

nealstewart commented 10 years ago

LGTM pending :white_check_mark: