search

gojek / courier-iOS

Courier iOS
39 stars 15 forks source link

[Chore] - Allow secured connection by scheme param #24

Closed mazidahmad closed 1 year ago

mazidahmad commented 1 year ago

Hi, I just try to make an improvement in the connection option so that the user can use a secured connection without being limited by the port connection. I added the 'scheme' param which is used too in Courier Android so that can have the same name convention. In Courier Flutter, it has already added the 'scheme' param but when it passes to iOS method channels, the param 'scheme' is not used. I have tested it on my project case and it solved my connection problem.

alfianlosari commented 1 year ago

https://github.com/gojek/courier-iOS/actions/runs/5461557157/jobs/9939861757?pr=24 some test cases are failing, please update those to acommodate the new logic mas

mazidahmad commented 1 year ago

https://github.com/gojek/courier-iOS/actions/runs/5461557157/jobs/9939861757?pr=24 some test cases are failing, please update those to acommodate the new logic mas

Updated

mazidahmad commented 1 year ago

Sorry, there are some tests missing to update. Done