search

gojek / heimdall

An enhanced HTTP client for Go
http://gojek.tech
Apache License 2.0
2.63k stars 214 forks source link

Fixing ambiguous import on statsd client #112

Closed Nydan closed 3 years ago

Nydan commented 3 years ago

Possible issue that produced by the v7.0.1

        github.com/gojek/heimdall/v7/hystrix imports
        github.com/afex/hystrix-go/plugins imports
        github.com/cactus/go-statsd-client/statsd: ambiguous import: found package github.com/cactus/go-statsd-client/statsd in multiple modules:
        github.com/cactus/go-statsd-client v3.0.1+incompatible (/Users/danny/go/pkg/mod/github.com/cactus/go-statsd-client@v3.0.1+incompatible/statsd)
        github.com/cactus/go-statsd-client/statsd v0.0.0-20200728222731-a2baea3bbfc6 (/Users/danny/go/pkg/mod/github.com/cactus/go-statsd-client/statsd@v0.0.0-20200728222731-a2baea3bbfc6)
coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 91.105% when pulling 47cb8ce3b43e2f99183ec079d008d765cac0d6ea on Nydan:fix-ambiguous-import into 9ffb3f7d342e1ca5901e6358adb537637055fde2 on gojek:master.