search

gojek / heimdall

An enhanced HTTP client for Go
http://gojek.tech
Apache License 2.0
2.63k stars 214 forks source link

Requests are being hardcoded to get close after response #121

Open Matias-Barrios opened 3 years ago

Matias-Barrios commented 3 years ago

hello folks, why is this line hardcoded? https://github.com/gojek/heimdall/blob/ca8c352034e638e32e00f1aaf3d01ff4625dd9af/httpclient/client.go#L125

It's stopping me from reusing the connections which might improve the performance of my app.

Matias-Barrios commented 3 years ago

I have created a PR for this : https://github.com/gojek/heimdall/pull/122/files