Add plugin support - Githubissues

gojek / heimdall

An enhanced HTTP client for Go

http://gojek.tech

Apache License 2.0

2.63k stars 214 forks source link

Add plugin support #40

Closed sohamkamani closed 4 years ago

sohamkamani commented 6 years ago

Plugins add support for sending request metrics, and logging #2

rShetty commented 6 years ago

@sohamkamani A major change to the structure of the API has landed on master, can you plz rebase with master and inculcate the new changes. Thanks

rShetty commented 6 years ago

@sohamkamani Merge conflicts

rShetty commented 5 years ago

@sohamkamani You want to look at fixing merge conflicts, will have a look and merge it

sohamkamani commented 5 years ago

@rShetty Yes! Will look at the conflicts and let you know!

coveralls commented 5 years ago

Coverage increased (+12.8%) to 100.0% when pulling 31c1ef9a784ee6e4241f5624c23fc891ef566520 on plugins into ef69e0bb0cbf72e832303efe6362855811e8cc89 on master.

rShetty commented 5 years ago

@sohamkamani Coverage 🤔

sohamkamani commented 5 years ago

ya its a bit misleading since I added the mock to the main package.. fixing this

sohamkamani commented 5 years ago

@rShetty is this ok to be merged?

rShetty commented 5 years ago

@sohamkamani Will review this, sorry for the delay, caught up with multiple things. Will review so soon. thanks

jjafuller commented 5 years ago

Has there been any progress on this? I was just about to wire in httptrace, but I would rather use this if possible.

unmultimedio commented 4 years ago

Hello, is there any progress on this? Is this repo still being maintained?