search

gojek / heimdall

An enhanced HTTP client for Go
http://gojek.tech
Apache License 2.0
2.63k stars 214 forks source link

Response Headers #5

Closed dimiro1 closed 6 years ago

dimiro1 commented 6 years ago

What if I need access to the response headers? Right now the Response [1] struct has no way to get them.

[1] https://github.com/gojektech/heimdall/blob/master/response.go#L4

devdinu commented 6 years ago

Since the method returns a custom heimdall.Response, headers are lost (we can't access). ideally we could change it to *http.Response if there's no other need for it.

rShetty commented 6 years ago

This is fixed in #10 . Thanks to @sohamkamani