search

gojek / proctor

A Developer-Friendly Automation Orchestrator
Apache License 2.0
123 stars 42 forks source link

Alternative methods to specify input parameters for procs #75

Open shishir127 opened 5 years ago

shishir127 commented 5 years ago

When input parameters for a proc are large, it sometimes becomes difficult to verify the input params one last time before executing a proc. Does it make sense to add a feature to the CLI to read input params from a JSON file?

olttwa commented 5 years ago

@shishir127 It makes sense to add this feature. This has been requested previously by @jasoet too.

olttwa commented 5 years ago

@asheet-bhaskar @RajatVaryani any takers for this?

RajatVaryani commented 5 years ago

@olttwa Sounds interesting and required. Let's do this.

olttwa commented 5 years ago

@RajatVaryani awesome. One thing though, let's keep the input file a yaml instead of json.

There won't be any nesting so there shouldn't be any confusion reading the file with all the indentations that come alongwith yaml files.

@shishir127 does that sound good?

shishir127 commented 5 years ago

we could make it simpler if required by reading from a .env file as well, but YAML works too