search

gojek / proctor

A Developer-Friendly Automation Orchestrator
Apache License 2.0
123 stars 43 forks source link

Fix PROCTOR_URL behaviour #8

Closed satyanash closed 5 years ago

satyanash commented 6 years ago

The PROCTOR_URL name of the config variable implies that it must be a URL. But in the code, it is used as the hostname. This is confusing.

Example lines: https://github.com/gojektech/proctor/blob/master/daemon/client.go#L42 https://github.com/gojektech/proctor/blob/master/daemon/client.go#L64

satyanash commented 6 years ago

One solution would be to support a few more config options like PROCTOR_HOST. And change the behaviour of PROCTOR_URL to support a full base URL.

satyanash commented 6 years ago

I have raised a PR to make it less confusing in the meantime: https://github.com/gojektech/proctor/pull/7