Make packages be independent of config package

gojek / weaver

An Advanced HTTP Reverse Proxy with Dynamic Sharding Strategies

Apache License 2.0

602 stars 53 forks source link

Make packages be independent of config package #16

Open rShetty opened 5 years ago

rShetty commented 5 years ago

currently packages are dependent on config package
make them independent by injecting config rather depending on them through package

RajatVaryani commented 5 years ago

@rShetty Can I pick this up?

rShetty commented 5 years ago

@RajatVaryani Sure go ahead, thanks

RajatVaryani commented 5 years ago

@rShetty Before starting just want to understand how injecting it would help. I am still unclear.

rShetty commented 5 years ago

@RajatVaryani The plan was that since we have tight dependency to config package from other packages with some packages needing to depend on a global object in config package, it is difficult to use some of these packages in isolation. The idea was to make it injectable so that we remove dependency on it

SameerKhurana commented 3 years ago

@rShetty is it still required ?