search

gojek / weaver

An Advanced HTTP Reverse Proxy with Dynamic Sharding Strategies
Apache License 2.0
602 stars 53 forks source link

ACL: Add tests #22

Closed palash25 closed 5 years ago

palash25 commented 5 years ago

Related to: https://github.com/gojektech/weaver/issues/20

cc @rShetty

rShetty commented 5 years ago

@palash25 Checks are failing

palash25 commented 5 years ago

@rShetty the following echo command is failing

$ echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin Must provide --username with --password-stdin The command "echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin" failed and exited with 1 during .

I am not really sure how it is related to my test, it was passing locally.

I tried a rebuild but I am getting the same failure.

Any ideas on how to fix that?

gwthm-in commented 5 years ago

@palash25 fixed it in this 59995fef1e88dbb087980236bd2f7b0e60bdc6a7 commit.

palash25 commented 5 years ago

thanks @gowtham-sai repushed. Tests are passing now :smile:

rShetty commented 5 years ago

@palash25 You might want to add more tests

palash25 commented 5 years ago

@rShetty I will push a few more test cases in the coming days