search

gojekfarm / xtools

XTools is a submodule based repo to host re-usable Golang code.
MIT License
5 stars 0 forks source link

Validate Consumer & Producer configs #41

Closed sonnes closed 2 months ago

sonnes commented 2 months ago

This PR separates consumer and producer configs and adds validation for mandatory options.

This PR also introduces a breaking change. xkafka.ErrorHandler is now mandatory while creating consumer or producer

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.15%. Comparing base (fecad69) to head (7d22c9c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #41 +/- ## ========================================== - Coverage 98.21% 98.15% -0.06% ========================================== Files 42 44 +2 Lines 895 922 +27 ========================================== + Hits 879 905 +26 - Misses 16 17 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.