search

gojp / goreportcard

A report card for your Go application
https://goreportcard.com
Apache License 2.0
2.01k stars 249 forks source link

errcheck without any errors is reported as '0%' #147

Closed fd0 closed 8 years ago

fd0 commented 8 years ago

Hi,

for my project restic the errcheck check does not return anything, but it is reported as 0%: https://goreportcard.com/report/github.com/restic/restic#errcheck

2016-07-29-213038_1135x190_scrot

I think that's wrong, the percentage should be the other way around...

hermanschaaf commented 8 years ago

Strange; this normally happens when a check fails to run. Whatever the reason was for the failure before though, I refreshed it just now and there were no errors:

screenshot from 2016-07-30 06 57 08

hermanschaaf commented 8 years ago

The errcheck test is reasonably new and is giving some issues on certain repos (can be slow, or not report missing error checks), so I'm disabling it for now. We can re-enable it once the issues are sorted out.

To better address this in the future, from now on if a test fails because of a timeout or other error, the error will be reported in the UI:

gocyclo error

fd0 commented 8 years ago

Thanks for taking a look! Great project by the way :smiley: