search

gojp / goreportcard

A report card for your Go application
https://goreportcard.com
Apache License 2.0
2.01k stars 249 forks source link

Sync using actual default branch #353

Closed ahmedalhulaibi closed 3 years ago

ahmedalhulaibi commented 3 years ago

Addressing #352

This adds go-git as a dependency and uses it to fetch HEAD and the default branch name. This way this project can support any default branch main, master, dev, etc.

ahmedalhulaibi commented 3 years ago

This should also address #354

ahmedalhulaibi commented 3 years ago

@shawnps @hermanschaaf any chance this can get a review?

ahmedalhulaibi commented 3 years ago

This should also address #357

shawnps commented 3 years ago

@ahmedalhulaibi we're now using the Go module proxy to download .zip files of module contents, so this git code doesn't exist anymore. Thanks for the contribution but I'm going to go ahead and close this PR.

georgettica commented 3 years ago

@shawnps could you then deprecate this repo and make this in the README? I would want anyone using this tool to not go on this rabbit hole aswell

shawnps commented 3 years ago

@georgettica sorry, deprecate the repo?

Since we're using the Go module proxy to download module contents, branch name doesn't matter anymore. Let me know if you have any questions about that.

georgettica commented 3 years ago

Oh sorry, I thought it was a different PR entirely (lost my context) Oki! Thanks :)

shawnps commented 3 years ago

@georgettica no worries! Feel free to open issues if you have any other requests 😄

georgettica commented 3 years ago

I'll reopen and tag you :)