Upgrade to go 1.17 to fix ineffassign issues with new stdlib functions

gojp / goreportcard

A report card for your Go application

https://goreportcard.com

Apache License 2.0

2.01k stars 249 forks source link

Upgrade to go 1.17 to fix ineffassign issues with new stdlib functions #356

Closed dechristopher closed 3 years ago

dechristopher commented 3 years ago

time.Time.UnixMilli was added in go1.17

thediveo commented 3 years ago

Looks like ineffassign has other hiccups too: for github.com/thediveo/netdb it reports missing identifiers that clearly exist.

jimschubert commented 3 years ago

ineffassign also reports incorrectly like this for String() methods generated by golang.org/x/tools/cmd/stringer

fly33499 commented 3 years ago

I want to upgrade it!!!!! plz!!

shawnps commented 3 years ago

@dechristopher @TheDiveO @jimschubert I believe this has been fixed and I don't see ineffassign issues on the repos you posted above. Feel free to reopen if that's not the case.

thediveo commented 3 years ago

looks good, thank you very much!