search

gojp / goreportcard

A report card for your Go application
https://goreportcard.com
Apache License 2.0
2.01k stars 249 forks source link

Old tag in goreportcard.com #388

Open smutel opened 2 years ago

smutel commented 2 years ago

Hello,

I don't understand why a old tag of my repo is reported in goreportcard.com ?

https://goreportcard.com/report/github.com/smutel/terraform-provider-netbox => v1.3.0

This tag has been released one year ago ...

How to use the last tag ?

Thanks.

shawnps commented 2 years ago

Hi @smutel

I think Go treats anything above v1 differently:

https://go.dev/doc/modules/release-workflow#breaking

You may be able to update your go.mod to:

module github.com/smutel/terraform-provider-netbox/v4

smutel commented 2 years ago

I updated the go.mod and I click on the refresh button. However the version is still 1.3.0 in goreportcard.com.

shawnps commented 2 years ago

@smutel Not totally sure but you may need a v4 dir:

https://research.swtch.com/vgo-module

In this case, v2.0.0 is created not by forking the whole tree into a separate branch but by copying it into a subdirectory. Again the go.mod must be updated to say "my/thing/v2". Afterward, v1.x.x tags pointing at commits address the files in the root directory, excluding v2/, while v2.x.x tags pointing at commits address the files in the v2/ subdirectory only.

We are basically doing the same thing as pkg.go.dev, and you can see they also show v1.3.0 for your module.

smutel commented 2 years ago

Is-it possible to specify a branch or a tag when we ask goreportcard.com to generate a report ?

apprehensions commented 1 year ago

still facing this issue