search

gojp / goreportcard

A report card for your Go application
https://goreportcard.com
Apache License 2.0
1.99k stars 252 forks source link

Refresh not working #415

Closed agity7 closed 1 year ago

agity7 commented 1 year ago

Hello, I own PnutMux routing module at gitlab.com/fruitygo/pnutmux.

https://goreportcard.com/report/gitlab.com/fruitygo/pnutmux

Sadly, even after correcting the following lines, I use the refresh button to obtain a 100% rating, but it always keeps showing the same result:

router.go Line 178: warning: ineffectual assignment to p (ineffassign) Line 179: warning: ineffectual assignment to qp (ineffassign) Line 178: warning: ineffectual assignment to p (ineffassign) Line 179: warning: ineffectual assignment to qp (ineffassign)

shawnps commented 1 year ago

Hi @fruitygo, you may need to tag v1.3.2 for the changes to get picked up.

agity7 commented 1 year ago

@shawnps Hi, I incremented the tag version to v1.3.2 and the report is still showing ineffassign errors from many commits ago.

agity7 commented 1 year ago

It worked, finally. THanks.