search

gojp / goreportcard

A report card for your Go application
https://goreportcard.com
Apache License 2.0
2.01k stars 249 forks source link

goreportcard no longer works with custom import paths #94

Closed bufdev closed 8 years ago

bufdev commented 8 years ago

https://go.pedge.io

All of them worked before. I just added a new one, https://go.pedge.io/base, and it does not work. I tried refreshing the others and they do not work anymore either. The error "Could not go get the repository" https://github.com/gojp/goreportcard/issues/90 is happening.

Did you change from doing git clone to go get? If so, this will not work for anything that enforces custom import paths https://github.com/peter-edge/base-go/blob/master/base.go#L1, which may seem like a minor use case, but this basically rules out a lot of repos such as https://goreportcard.com/report/github.com/grpc/grpc-go. If this was changed, it should go back to the former clone method.

bufdev commented 8 years ago

Ya https://github.com/gojp/goreportcard/commit/8b1d3a056647fd319a4e09697c19970c4e764591

At the very least, this should remain a backup option.

bufdev commented 8 years ago

Ah, I can do https://goreportcard.com/report/go.pedge.io/base, which is correct.