search

gojuno / composer

Reactive Android Instrumentation Test Runner. Archived. Marathon is recommended as an alternative (https://github.com/Malinskiy/marathon).
Apache License 2.0
544 stars 45 forks source link

Add configurable APK installation timeout. #109

Closed koral-- closed 6 years ago

koral-- commented 7 years ago

https://github.com/gojuno/commander/issues/7 continuation.

artem-zinnatullin commented 6 years ago

@koral-- thanks!

Pls report if it solved your issue :)

koral-- commented 6 years ago

OK, thanks for the quick response. I'll create appropriate PR in https://github.com/trevjonez/composer-gradle-plugin and check it ASAP.

artem-zinnatullin commented 6 years ago

Oh, so you use Gradle Plugin, patching 3 repositories is not so fun I guess, glad we have fast and easy release process :)

On Thu, Nov 9, 2017, 3:32 PM Karol Wrótniak notifications@github.com wrote:

OK, thanks for the quick response. I'll create appropriate PR in https://github.com/trevjonez/composer-gradle-plugin and check it ASAP.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/gojuno/composer/pull/109#issuecomment-343326564, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7B3HXG0BZNQnjiLF-17QrkcSoovtdzks5s04t7gaJpZM4QVqEW .

trevjonez commented 6 years ago

I have an issue open for it there already. https://github.com/trevjonez/composer-gradle-plugin/issues/8

Shoot me a pr or I can get it in and updated first thing in the morning.

trevjonez commented 6 years ago

this repo is in need of a readme update to reflect this new flag.

koral-- commented 6 years ago

Just added README update in #110. I'll try to create PR in plugin repo ASAP.

yunikkk commented 6 years ago

Oh, and other flags, I guess. Will add them separately.

trevjonez commented 6 years ago

pr is up for this. any review is welcome. thus far the gradle plugin has been a solo effort so I will merge in an hour or so if nothing moves on it

koral-- commented 6 years ago

@artem-zinnatullin

Pls report if it solved your issue :)

I would said that it is partially solved. Indeed installation time is not an issue now. So change from this PR is OK.

But it seems that installation hangs when output file reaches 64KB. I'll investigate that further and create separate issue possibly.

artem-zinnatullin commented 6 years ago

@koral-- yeah, what a "wonderful" world of programmatic binary invocations…