search

gojuno / composer

Reactive Android Instrumentation Test Runner. Archived. Marathon is recommended as an alternative (https://github.com/Malinskiy/marathon).
Apache License 2.0
544 stars 45 forks source link

Updated handling of crashed application during test run. #130

Closed yunikkk closed 6 years ago

yunikkk commented 6 years ago

Basically, thats it, fixes #121)

It appears that crashes are reported differently under different OS revisions. I've got another example with shortMsg=Native crash on Lollipop, too. So the common thing here is shortMsg and it should be sufficient to treat it as crash.

With this PR test run will fail, but the excluded tests will remain silently ignored. Seems to me that possible nicer option would be to refactor error handling the way that other tests are reported as ignored. On the other hand it will be confusing, too.

IMO we can live with such solution until we integrate test orchestrator or our own test runner which will run tests independently and allow to restart crashed application and failed test.

WDYT @artem-zinnatullin ?

artem-zinnatullin commented 6 years ago

the way that other tests are reported as ignored. On the other hand it will be confusing, too.

Yeah, I wouldn't mess with that. Ignored means that they were ignored in the code, ie with @Ignore

yunikkk commented 6 years ago

Hey @artem-zinnatullin , lets merge this?

artem-zinnatullin commented 6 years ago

Yeah sorry, I think GitHub stopped sending emails when you push new commits :(