search

gojuno / composer

Reactive Android Instrumentation Test Runner. Archived. Marathon is recommended as an alternative (https://github.com/Malinskiy/marathon).
Apache License 2.0
546 stars 45 forks source link

Fix Logcat Parsing #133

Closed christopherperry closed 6 years ago

christopherperry commented 6 years ago

Fix for #129

Might need more testing.

artem-zinnatullin commented 6 years ago

Btw, looks like you're committing with wrong git config, your commit doesn't have your avatar

You can check if commit email matches expected that is attached to github account:

git log

And if it's not, fix it like that:

git config user.email "correct@email.com"
git commit -a --amend --reset-author
artem-zinnatullin commented 6 years ago

Ah, also please add test case(s) that show how old parsing failed and new one fixes that problem! Thanks :)

christopherperry commented 6 years ago

@artem-zinnatullin Please have another look. I optimized and added some tests.

christopherperry commented 6 years ago

bump

artem-zinnatullin commented 6 years ago

Just in case, I believe when GitHub will "Squash and Merge" it'll use first commit as base and might not associate it with your GitHub account, but I'm not sure

Possible solution: rebase with --reset-author and force push, but it's up2u :)

christopherperry commented 6 years ago

Fixed. Thanks @artem-zinnatullin

artem-zinnatullin commented 6 years ago

@yunikkk can you PTAL and merge? :)

evgengal commented 6 years ago

Please, merge!)

christopherperry commented 6 years ago

@evgengal I just built a jar and deployed that so I wouldn't have to wait. Put a fix for screenshots not working in there too, but it's kind of a special case.

yunikkk commented 6 years ago

@christopherperry merged and released 0.3.3 with it, thanks!

CristianGM commented 6 years ago

Well...now it doesn't work on emulators... because of: https://github.com/gojuno/composer/blob/master/composer/src/main/kotlin/com/gojuno/composer/TestRun.kt#L166

/storage/emulated/0 doesn't exist in emulators with API 22...

Sloy commented 6 years ago

I just created a new issue for what @CristianGM is commenting, in case you'd like to treat it as a different issue: https://github.com/gojuno/composer/issues/151

yunikkk commented 6 years ago

@CristianGM @Sloy thanks for reporting, adding fix.