search

gojuno / composer

Reactive Android Instrumentation Test Runner. Archived. Marathon is recommended as an alternative (https://github.com/Malinskiy/marathon).
Apache License 2.0
546 stars 45 forks source link

Docker builds not using cache #134

Open christopherperry opened 6 years ago

christopherperry commented 6 years ago

Every build through docker does a lot of things that could probably be cached. I couldn't get a local build to work, so iterating via the docker build is quite a pain.

artem-zinnatullin commented 6 years ago

You mean ci/build.sh right?

Just want to make sure you're not talking about dockerized integration of Composer in your project :)

artem-zinnatullin commented 6 years ago

I see a PR from you, so I can assume you mean ci/build.sh

artem-zinnatullin commented 6 years ago

Yeah, build is not as fast as I'd like it to be,

Quick suggestion tho: you don't need to run it through Docker every time, you can build it once so we have generated HTML report files and then just iterate over composer module with Gradle/IDE: ./gradlew build

christopherperry commented 6 years ago

@artem-zinnatullin Sorry for the late reply, yes I'm talking about ci/build.sh

christopherperry commented 6 years ago

Quick suggestion tho: you don't need to run it through Docker every time, you can build it once so we have generated HTML report files and then just iterate over composer module with Gradle/IDE: ./gradlew build

Awesome. Ok. Maybe that should be added to the README? I tried to build via Gradle and had a test failure which I found confusing so I reached for the docker build.

artem-zinnatullin commented 6 years ago

Let me try to optimize Docker build first :)

artem-zinnatullin commented 6 years ago

It's a bit tricky to cache properly, I'm gonna do few incremental improvements first