search

gojuno / composer

Reactive Android Instrumentation Test Runner. Archived. Marathon is recommended as an alternative (https://github.com/Malinskiy/marathon).
Apache License 2.0
546 stars 45 forks source link

Install extra APKs if received ( useful for Orchestrator ) #159

Closed CristianGM closed 5 years ago

CristianGM commented 5 years ago

Now that we allow to use Orchestrator it would be nice to install the APKs required by Orchestrator to run. Instead of being specific for Orchestrator this PR allows devs to install any extra APK they need.

There are no tests or documentation written yet because I want to validate the approach taken first, if it's ok I'll update the docs and add some tests ( suggestions on which ones are welcomed )

CristianGM commented 5 years ago

I made it more generic, now any APK used by tests: orchestrator, test-butler-app, ... can be installed

what do you think @jonas-m- ? I think it does exactly what you suggested on your PR ( with the help of the plugin is just magic )

CristianGM commented 5 years ago

@yunikkk ?

jonas-m- commented 5 years ago

I made it more generic, now any APK used by tests: orchestrator, test-butler-app, ... can be installed

what do you think @jonas-m- ? I think it does exactly what you suggested on your PR ( with the help of the plugin is just magic )

Yep - looks good - liking the generic approach :)

trevjonez commented 5 years ago

What machanism is used to install apks to the device? (I assume commander houses that functionality). I gave instant run another try this last week (still terrible) and noticed it used a single adb command to push all the apk files in one go. Not sure it would make any difference but might be worth looking at?

artem-zinnatullin commented 5 years ago

We use adb install if nothing changed. Instant run is not suitable for installs from scratch, it does push files and then uses tricks like custom classloader to hot swap to new stuff

artem-zinnatullin commented 5 years ago

@yunikkk, @ming13 let's merge and release an update? I have rights to do a release, but not to merge

yunikkk commented 5 years ago

Guess ming13 added the merge permissions for you already...

artem-zinnatullin commented 5 years ago

Yep!