search

gojuno / composer

Reactive Android Instrumentation Test Runner. Archived. Marathon is recommended as an alternative (https://github.com/Malinskiy/marathon).
Apache License 2.0
546 stars 45 forks source link

Fix js issue when displaying stacktraces in report #161

Open f-lolom opened 5 years ago

f-lolom commented 5 years ago

Hi everyone,

everything is in the title : the JS in TestItem.js is broken. The following error occurs in the JS console when opening a "test details" page:

Uncaught TypeError: Cannot read property 'length' of undefined
    at t.value (app.min.js:25)
    at app.min.js:97
    at s (app.min.js:97)
    at h._renderValidatedComponentWithoutOwnerOrContext (app.min.js:97)
    at h._renderValidatedComponent (app.min.js:97)
    at h.performInitialMount (app.min.js:97)
    at h.mountComponent (app.min.js:97)
    at Object.mountComponent (app.min.js:6)
    at g.mountChildren (app.min.js:97)
    at g._createInitialChildren (app.min.js:97)

Concretely, this error was preventing the "title" and the "screenshot" section to be displayed to the user.

The bug was introduced by this commit : https://github.com/gojuno/composer/commit/b0c12ea6e2b72c8e5a52ecbcaac72601477de119

tir38 commented 5 years ago

@artem-zinnatullin @yunikkk @ming13 Can you 👀 when you have time? This one-line fix would help us out a lot.

tir38 commented 5 years ago

@f-lolom I don't suppose you'd be willing to rebase this PR and issue a new version of your own lib to capture this one more-recent commit https://github.com/gojuno/composer/commit/2ff3f575152df48ee2659bbe746610dd633a04f7

nimeacuerdo commented 5 years ago

Hi, any news on this?

nimeacuerdo commented 5 years ago

This is working for us in the meantime.

flolom commented 5 years ago

@tir38 I've updated my fork : com.flolom.composer:composer:0.6.1

tir38 commented 5 years ago

@f-lolom thanks that worked.