search

gojuno / composer

Reactive Android Instrumentation Test Runner. Archived. Marathon is recommended as an alternative (https://github.com/Malinskiy/marathon).
Apache License 2.0
546 stars 45 forks source link

Add support for AndroidX Test Orchestrator #167

Closed plastiv closed 5 years ago

plastiv commented 5 years ago

Fixes https://github.com/gojuno/composer/issues/166

Another approach would be to keep --with-orchestrator but release composer supporting androidx only.

trevjonez commented 5 years ago

In my mind support for the old orchestrator should just be dropped. For those still using it, they can stay on the older version as long as required before they migrate. Which is exactly what they are choosing to do on their support lib code that actually ships to their user base.

artem-zinnatullin commented 5 years ago

Damn androidx rename breaks everything on its way

Let's drop support for old orchestrator altogether as @trevjonez commented

plastiv commented 5 years ago

Okay 👍

Note: I've made a breaking change by forcing passing true or false parameter. --with-orchestrator true. I think it is more consistent usage with other params and with current documentation.

cc https://github.com/gojuno/composer/issues/158

plastiv commented 5 years ago

Applied both suggestions let me know if anything else is needed 🙏

tir38 commented 5 years ago

@artem-zinnatullin is there a plan to get a release out w/ this fix or are you waiting at the moment?

artem-zinnatullin commented 5 years ago

@tir38 just cut the release, sorry for delay

CristianGM commented 5 years ago

I'm too late, but making a breaking change just because it seems more consistent...is bad, now https://github.com/trevjonez/composer-gradle-plugin needs and update too instead of just working nicely. 😢

tir38 commented 5 years ago

I'm curious how this broke the gradle plugin. Is the plugin not pinned to a specific version of Composer? Or does it always grab the latest?

CristianGM commented 5 years ago

No, it didn't break because it's pinned, but it provides the option to override composer version.

The difference is, we could use the latest version of composer with the current plugin without any change, now it requires to do a PR on the plugin to fix the parameter, update the composer version and do another release. Not a big issue, just that IMHO breaking the API is something we should do only when it's really required.

On Thu, 28 Mar 2019, 16:34 Jason Atwood, notifications@github.com wrote:

I'm curious how this broke the gradle plugin. Is the plugin not pinned to a specific version of Composer? Or does it always grab the latest?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/gojuno/composer/pull/167#issuecomment-477648021, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkkBB-1vbmnvIBuBy6rzcBZu7-NvJqhks5vbOEZgaJpZM4a2hP- .