gojuno / composer

Reactive Android Instrumentation Test Runner. Archived. Marathon is recommended as an alternative (https://github.com/Malinskiy/marathon).
Apache License 2.0
546 stars 45 forks source link

Ability to return 0 exit code in case of test failures #179

Closed vdoshkinn closed 4 years ago

vdoshkinn commented 4 years ago

Hi! Could you please add some key to return 0 exit code when some tests were failed? I'm going to execute my test suite using composer and now composer step breaks my CI pipeline in the middle because 1 exit code returns in case of failed test.

Thank you in advance

trevjonez commented 4 years ago

if you wrap your invocation of composer in a bash script you should be able to achieve this without change to the library. additionally it is likely that changes to the process contract like this would result in breaking a ton of other workflows.

artem-zinnatullin commented 4 years ago

Please handle it in your ci pipeline, something like this will work if you can wrap it in bash:

bash -c "set +e; java -jar composer...."

On Tue, Oct 1, 2019, 10:44 AM Trevor Jones notifications@github.com wrote:

if you wrap your invocation of composer in a bash script you should be able to achieve this without change to the library. additionally it is likely that changes to the process contract like this would result in breaking a ton of other workflows.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gojuno/composer/issues/179?email_source=notifications&email_token=AAHMDXAPH7GVUSEXEP7ITGTQMOD6ZA5CNFSM4I4MIQR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEACD6GY#issuecomment-537149211, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHMDXHYEUIXRO3KTETZK3LQMOD6ZANCNFSM4I4MIQRQ .

vdoshkinn commented 4 years ago

Thanks guys for the quick response. "java -jar composer.. || exit 0" works for me.