gojuno / composer

Reactive Android Instrumentation Test Runner. Archived. Marathon is recommended as an alternative (https://github.com/Malinskiy/marathon).
Apache License 2.0
546 stars 45 forks source link

Added the ability to pass in device ids to filter the execution on those devices only #85

Closed jurenovic closed 7 years ago

jurenovic commented 7 years ago

Ability to filter execution on provided emulator/device ids. Usage: --devices emulator-5554 or --devices emulator-5554 emulator-5556 ...

artem-zinnatullin commented 7 years ago

I'll take a look soon, it's useful feature, but we need to design it carefully!

On Fri, Jul 21, 2017, 06:16 Dmitry Yunitsky notifications@github.com wrote:

@yunikkk requested changes on this pull request.

Extra apply block

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gojuno/composer/pull/85#pullrequestreview-51470402, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7B3JiL6faDpybVVS7BKWz_-mqgaopmks5sQKShgaJpZM4OfOGo .

artem-zinnatullin commented 7 years ago

@yunikkk let's merge it and make a release so @jurenovic could use it?

You just need to make a release on GitHub and that will trigger CI job that'll deploy new version to Bintray 😸

arturdryomov commented 7 years ago

This branch is out-of-date with the base branch

I can update branch via GitHub UI, but can you please do it yourself? Don’t want to cause merge conflicts.

artem-zinnatullin commented 7 years ago

I think it's alright for you to update branch, we've accepted all changes in the PR and should do everything to merge it on our own!

jurenovic commented 7 years ago

@artem-zinnatullin @ming13 @yunikkk thanks guys