Add the component1 operator to Optional - Githubissues

gojuno / koptional

Minimalistic Optional type for Kotlin that tries to fit its null-safe type system as smooth as possible.

Apache License 2.0

289 stars 21 forks source link

Add the component1 operator to Optional #20

Closed AlecKazakova closed 6 years ago

AlecKazakova commented 6 years ago

Closes #19

artem-zinnatullin commented 6 years ago

This change introduces funny construct btw:

val (lol: Nothing?) = None

artem-zinnatullin commented 6 years ago

jeez, Koptional is like 3 types and 2 functions and we already have one PR that breaks compatibility and now this one is actually not that simple even though it adds just one function hahaha I just can't killme

artem-zinnatullin commented 6 years ago

@AlecStrong can you please update PR with things we've discussed?

artem-zinnatullin commented 6 years ago

@AlecStrong if you don't have bandwidth, I can manually merge it with feedback addressed, wdyt?

No pressure though :)

AlecKazakova commented 6 years ago

no worries - i was just on vacation but im back now and can update

artem-zinnatullin commented 6 years ago

Niiice! A vacation would be so nice…

// Can you pls resolve conflicts?

artem-zinnatullin commented 6 years ago

@AlecStrong we gonna merge it as is and submit additional PR to address remaining feedback to push release sooner :)