gojuno / minimock

Powerful mock generation tool for Go programming language
MIT License
632 stars 38 forks source link

Checksums of v3.3.10 are wrong #104

Closed suzuki-shunsuke closed 4 months ago

suzuki-shunsuke commented 4 months ago

https://github.com/gojuno/minimock/releases/tag/v3.3.10

Download all assets.

$ gh -R gojuno/minimock release download v3.3.10

Verify checksums, then the verification fails.

$ sha256sum -c checksums.txt 
minimock_3.3.10_darwin_amd64.tar.gz: FAILED
minimock_3.3.10_darwin_arm64.tar.gz: FAILED
minimock_3.3.10_linux_386.tar.gz: FAILED
minimock_3.3.10_linux_amd64.tar.gz: FAILED
minimock_3.3.10_linux_arm64.tar.gz: FAILED
minimock_3.3.10_windows_386.tar.gz: FAILED
minimock_3.3.10_windows_amd64.tar.gz: FAILED
minimock_3.3.10_windows_arm64.tar.gz: FAILED
sha256sum: WARNING: 8 computed checksums did NOT match

checksums.txt

5cbca9b0149e5ff023971b28df8582f183638456595db0af0bdeebe95a763234  minimock_3.3.10_darwin_amd64.tar.gz
1aec814014035b3b8577a11601e122694eb4c816d8da29bcbb5d1733591374bf  minimock_3.3.10_darwin_arm64.tar.gz
09ef2e28528e896c28d4734d5a82da10fbd0dcd8f8ac0c159c8faa5e4f80625e  minimock_3.3.10_linux_386.tar.gz
9b952ba4cff7c37dfcfbed17a2eecacb99b0ce4acd12533d17aec6d77134c687  minimock_3.3.10_linux_amd64.tar.gz
cc86c25700916bc9259dbcad080e6260ba45c0f11ad1b96d322606ab42702084  minimock_3.3.10_linux_arm64.tar.gz
cef7c3cb6b89f0354d894de2bdaf3b8294dce56ba29874e84925f30fe71aea97  minimock_3.3.10_windows_386.tar.gz
4c5d091650e476dcc4680233a97056287b9ca385cc7c6588f6c2f82cec6b3a17  minimock_3.3.10_windows_amd64.tar.gz
e73d7a90e95aa3d20252d268198f6a892e21d5c6ae5e6eb2a69d4635ddab088a  minimock_3.3.10_windows_arm64.tar.gz

Actual checksums.

$ sha256sum *.tar.gz
e86a7a19448c84366cc9671ba1eb25d2798ddf4e07522713d47b473d3f3fdc6f  minimock_3.3.10_darwin_amd64.tar.gz
08f71a6166f2c3b3b7410f1b7e1bdfe474d5a1c770a076938dddcbf8fb7beb81  minimock_3.3.10_darwin_arm64.tar.gz
2385092ccd2de382c4ac5234d9c7c7c358c14e4598e8f2160cc8cddbc2566d58  minimock_3.3.10_linux_386.tar.gz
1cddec5587ad88a3a16f4ef940fcb64f292d6e7df229ffb26a6b19ce2eb1ba94  minimock_3.3.10_linux_amd64.tar.gz
0aad764626886d2f1ba4a0825538faadfbf41edfba99e30242aeeefc4222dad6  minimock_3.3.10_linux_arm64.tar.gz
e4e362f5455ee03a965c9d3293c7cad5ea2eb4c3dfd1810d61eaa1d3d7d6f3be  minimock_3.3.10_windows_386.tar.gz
189bc10dc3b66e3cd3a74ff1ff427523123b5cadab8cc08899e26723afb59a1d  minimock_3.3.10_windows_amd64.tar.gz
ad65e2965f6d3142e8ba8e8eac4ded0e447bce72d35e3ba09a46a440177c61f5  minimock_3.3.10_windows_arm64.tar.gz
suzuki-shunsuke commented 4 months ago

The release workflow failed.

https://github.com/gojuno/minimock/actions/runs/9292501301/job/25573535768

• upload failed                                name=checksums.txt release-id=158062670 request-id=7402:23B045:C3E311:CDEACA:66578C70
      • failed to upload artifact, will retry        try=1 artifact=checksums.txt error=POST https://uploads.github.com/repos/gojuno/minimock/releases/158062670/assets?name=checksums.txt: 422 Validation Failed [{Resource:ReleaseAsset Field:name Code:already_exists Message:}]
      • took: 4s
  • took: 4s
  ⨯ release failed after 1m1s                error=scm releases: failed to publish artifacts: failed to upload checksums.txt after 1 tries: POST https://uploads.github.com/repos/gojuno/minimock/releases/1580626[70](https://github.com/gojuno/minimock/actions/runs/9292501301/job/25573535768#step:4:71)/assets?name=checksums.txt: 422 Validation Failed [{Resource:ReleaseAsset Field:name Code:already_exists Message:}]
Error: The process '/opt/hostedtoolcache/goreleaser-action/1.23.0/x64/goreleaser' failed with exit code 1
hexdigest commented 4 months ago

Hi @suzuki-shunsuke,

I think I triggered release locally and at the same time it was triggered by the github actions. I removed v3.3.10 tag and added v3.3.11

suzuki-shunsuke commented 4 months ago

Thank you for handling the issue.

I think we should remove the Make task release to prevent this issue. I've created a pull request.