search

gojuno / minimock

Powerful mock generation tool for Go programming language
MIT License
574 stars 38 forks source link

Proper usage of the go:generate comment convention #77

Closed ukirill closed 5 months ago

ukirill commented 9 months ago

Thanks for such a great library!

This Convention defines a comment location also

This line must appear before the first non-comment, non-blank text in the file.

So, comment should be placed before package line. Some tools strictly check this to recognize code-generated files.

What i did:

Looking forward for a review!

hexdigest commented 6 months ago

Hey @ukirill

Can you please update your branch? (I removed snapshots because there's not very much sense of having these)

ukirill commented 5 months ago

Hey @ukirill

Can you please update your branch? (I removed snapshots because there's not very much sense of having these)

Hi! I've realized that you've fixed this issue already in one of the recent commits 😄 Thanks! So, I'll close this PR