search

gokarna-theme / gokarna-hugo

A minimal opinionated theme for Hugo
https://gokarna-hugo.netlify.app
GNU General Public License v3.0
358 stars 140 forks source link

Add invisible screen reader target to mobile menu button. #121

Closed nebeker closed 2 years ago

nebeker commented 2 years ago

Similarly to the issue with screen readers not finding the dark mode toggle button, the mobile view menu button was also unreacheable. This is event worse, because it means a blind user is likely to not even know there's a menu, when browsing on a phone or with a narrow browser window on desktop. This change fixes the issue the same way.

netlify[bot] commented 2 years ago

Deploy Preview for gokarna-hugo ready!

Name Link
Latest commit 9435fd3b25a1c3ad1452eedfb2536fe839360483
Latest deploy log https://app.netlify.com/sites/gokarna-hugo/deploys/630a91be2a058d00098ed0c2
Deploy Preview https://deploy-preview-121--gokarna-hugo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

yashmehrotra commented 2 years ago

@nebeker Thanks for the PR :)

nebeker commented 2 years ago

@yashmehrotra No problem!