Closed jamesericdavidson closed 1 year ago
Name | Link |
---|---|
Latest commit | 7f70241f0e94171946826d39894a9f1995d01aea |
Latest deploy log | https://app.netlify.com/sites/gokarna-hugo/deploys/635aa87ec6830f00089042bb |
Deploy Preview | https://deploy-preview-124--gokarna-hugo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Fixed an odd bug with <hr>
in f591630ce4fd74e0ddd272f02a20f1de137b1d01.
I just built my own slightly uglier version of this, I think it's a great idea!
It might be wise to add a configuration option to toggle it on/off, similarly to how showPostsOnHomePage
controls whether or not posts are shown on the home page. The theme is so minimal that having this on by default is probably visual clutter for the average user.
@jamesericdavidson Thanks for the PR and sorry for the late reply.
Can you hide this feature behind a config parameter and add documentation to enable it ?
@jamesericdavidson Thanks for submitting the PR. I just have one small suggestion from the CSS side - let's make the whole text including the arrow and the word "Previous"/"Next" as a hyperlink to make it easier for the user. Something like:
@jamesericdavidson Any updates on this :) ?
The expanded hyperlinks, toggle and documentation are in.
The implementation is still naive thanks to default sort, which I'm less than thrilled by. But it works if you are willing to forego .Weight
.
@jamesericdavidson Thanks for implementing the updates!
Just one more thing - can you please add a screenshot to this PR for review of how the prev/next buttons look like? C
But it works if you are willing to forego .Weight.
Works for me. We can try to add it later. @yashmehrotra thoughts?
can you please add a screenshot to this PR for review of how the prev/next buttons look like?
With .Weight
removed from post YAML:
sed -i 's/weight: .*//' exampleSite/content/posts/*
And togglePreviousAndNextButtons = "true"
set in exampleSite/config.toml
:
If you want exampleSite
to appear this way, I can add the commit to this PR.
@yashmehrotra @526avijitgupta Happy to merge? :slightly_smiling_face:
LGTM. @yashmehrotra ?
ping @yashmehrotra - Let's merge?
Thanks for the PR @jamesericdavidson
Sorry for the delayed response
Screenshots
exampleSite
jamesdavidson.xyz
Default sort problem
Sadly, works poorly with
.Weight
due to Hugo's default sort, which prefers.Weight
over.Date
:This workaround does not seem to work either: https://www.feliciano.tech/blog/custom-sort-hugo-single-pages/
Feedback
If you think this is worth adding, I can look into using
.Date
instead of Hugo's default sort.I'd also appreciate feedback on the CSS, as I'm no designer.