gokarna-theme / gokarna-hugo

A minimal opinionated theme for Hugo
https://gokarna-hugo.netlify.app
GNU General Public License v3.0
358 stars 140 forks source link

Prevent long strings from overflowing #146

Closed jamesericdavidson closed 1 year ago

jamesericdavidson commented 1 year ago

Long strings with no spaces can overflow its container, especially on mobile.

This should rarely come into play, but it shouldn't hurt anything either.

Without the fix

image

With the fix

image

Relevant documentation

netlify[bot] commented 1 year ago

Deploy Preview for gokarna-hugo ready!

Name Link
Latest commit d7a0080d119d582404ea46d868707a77976a48c0
Latest deploy log https://app.netlify.com/sites/gokarna-hugo/deploys/63a0e623d206d10008be1392
Deploy Preview https://deploy-preview-146--gokarna-hugo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

yashmehrotra commented 1 year ago

Thanks for the PR @jamesericdavidson

LGTM, @526avijitgupta Can you take a look at this and merge if everything seems alright ?

jamesericdavidson commented 1 year ago

Thanks Yash.

I noticed on mobile that unbroken strings affect the header and hamburger menu - you have to scroll to the right to access the menu.

An edge case, but this does affect functionality rather than just a fix for something unsightly.

Regards, James Davidson

-------- Original Message -------- On Dec 20, 2022, 3:42 AM, Yash Mehrotra wrote:

Thanks for the PR @.***(https://github.com/jamesericdavidson)

LGTM, @.***(https://github.com/526avijitgupta) Can you take a look at this and merge if everything seems alright ?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

jamesericdavidson commented 1 year ago

@yashmehrotra @526avijitgupta Sorry to ping again. Does this PR look okay?

yashmehrotra commented 1 year ago

Sorry for the delay, Thanks @jamesericdavidson