gokarna-theme / gokarna-hugo

A minimal opinionated theme for Hugo
https://gokarna-hugo.netlify.app
GNU General Public License v3.0
357 stars 139 forks source link

Add possibility to write text with a markdown "about" file on the title page #179

Closed davidkroell closed 1 year ago

davidkroell commented 1 year ago

This adds the option (behind a feature-flag) to write more text onto the home page.

I had to change the source branch and the other PR #170 was unfortunately automatically closed.

Superceeds #170

netlify[bot] commented 1 year ago

Deploy Preview for gokarna-hugo ready!

Name Link
Latest commit 03758d61e3667e5ffa743bb1f8d17a2d7ac4cbf1
Latest deploy log https://app.netlify.com/sites/gokarna-hugo/deploys/64953b99dcb8f7000782f24f
Deploy Preview https://deploy-preview-179--gokarna-hugo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

davidkroell commented 1 year ago

@yashmehrotra I had to create another PR, which is essentially the same as #170.

Do we need this 3rd type ? Since its only for the homepage, can we just infer it via filename and its existense ?

Yea probably, but I'm fairly new to Hugo, so I don't know how. If you can provide a path for me, I can implement it.

yashmehrotra commented 1 year ago

Yea probably, but I'm fairly new to Hugo, so I don't know how. If you can provide a path for me, I can implement it.

Since the only place to add about is the index page, the path of the about file can be static. (For eg., content/index-about.md)

Our logic then will be:

davidkroell commented 1 year ago

@yashmehrotra I made the necessary changes, and the new version is far more straightforward.

yashmehrotra commented 1 year ago

Thanks for the PR @davidkroell