gokarna-theme / gokarna-hugo

A minimal opinionated theme for Hugo
https://gokarna-hugo.netlify.app
GNU General Public License v3.0
357 stars 139 forks source link

Move about page above social icons #187

Closed bliemli closed 1 year ago

bliemli commented 1 year ago

The pull request named Add possibility to write text with a markdown "about" file on the title page by @davidkroell (thank you!) introduced an about section that can be displayed on the landing page. I'm making this suggestion as the gokarna theme already allowed displaying content on the landing page by creating the file content/_index.md, as described in the documentation. As far as I understand it there's currently no real difference between the two. At the risk of overlooking or misunderstanding something, I have intentionally not updated the documentation yet but would do so if this change looks good to you.

netlify[bot] commented 1 year ago

Deploy Preview for gokarna-hugo ready!

Name Link
Latest commit 1ae00bc14db0c27603372e73f922667adaf4494d
Latest deploy log https://app.netlify.com/sites/gokarna-hugo/deploys/649d6a4b5ad1ec00084e389f
Deploy Preview https://deploy-preview-187--gokarna-hugo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

526avijitgupta commented 1 year ago

Hi @bliemli thanks for submitting the PR. I personally prefer to keep the about text below the social icons, as is the case right now. @yashmehrotra what are your thoughts on it?

yashmehrotra commented 1 year ago

@bliemli @526avijitgupta

Yeah, the about text should be (and is intentionally) below the social icons since there is no finite limit to the length of it and we don't want to push the social icons too much down, they already are below the title and description

Regarding the content/_index.md , yeah, thats a great catch. We should have only one way to do one thing and this is the hugo way. Will be deprecating the fixed file name in favour of that (I missed that with too many open PRs/issues. my bad)

bliemli commented 1 year ago

@526avijitgupta @yashmehrotra

Thank you both for looking into it! Your reasoning totally makes sense and I'm going to close the PR.