gokarna-theme / gokarna-hugo

A minimal opinionated theme for Hugo
https://gokarna-hugo.netlify.app
GNU General Public License v3.0
357 stars 139 forks source link

feat: display accurate copyright years on pages #233

Closed jamesericdavidson closed 3 weeks ago

jamesericdavidson commented 1 month ago

tl;dr Implementation for #222.

A long copyright string will overflow the .footer container, ergo some assistance on the CSS side would be greatly appreciated. :smiley:

N.B. Copyright is described by Hugo here: https://gohugo.io/methods/site/copyright/

netlify[bot] commented 1 month ago

Deploy Preview for gokarna-hugo ready!

Name Link
Latest commit 6268dd921d83f9c60ea718d3ccb6fe32427e5473
Latest deploy log https://app.netlify.com/sites/gokarna-hugo/deploys/66f3bde46067e20008dc4dae
Deploy Preview https://deploy-preview-233--gokarna-hugo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jamesericdavidson commented 1 month ago

Screenshots

Non-page kinds:

image

Page without .Date or .Lastmod:

image

Pages with .Date but not .Lastmod:

image

Pages with .Date and .Lastmod:

image

Sites with copyright:

image

jamesericdavidson commented 1 month ago

@yashmehrotra @526avijitgupta I hope this suits. Look forward to your review :+1:

jamesericdavidson commented 3 weeks ago

See #234

yashmehrotra commented 3 weeks ago

@jamesericdavidson I think we can leave the CSS problem for now since it only happens with very large texts which is not the usual case. Can you create a separate issue for this ?

I'll merge this for now, thanks for your contribution

jamesericdavidson commented 3 weeks ago

@yashmehrotra Brilliant, thanks Yash. Will do :+1: