gokarna-theme / gokarna-hugo

A minimal opinionated theme for Hugo
https://gokarna-hugo.netlify.app
GNU General Public License v3.0
357 stars 139 forks source link

docs(basics): update documentation for first-time users #243

Closed jamesericdavidson closed 4 days ago

jamesericdavidson commented 2 weeks ago

Summary

This PR aims to:

Work applies to Theme Documentation - Basics only. Advanced is unaffected, though Basics will continue linking to Advanced when appropriate.

N.B. Meaningful content changes are denoted in commits with the docs: message prefix.

To Do

Removed

Issues (for later PRs)

  1. Comments are often replicated between Basic Configuration, Configuration and individual params with little additional content, context, or links provided for further reading

    DRY. Only expand on the param if beneficial to the user, otherwise remove other instances of that feature's documentation (e.g. if the short comment in Basic Configuration is enough, only keep that instance).

  2. Basics and Advanced occasionally cannibalise each other's features with little additional content, context, or links provided for further reading

    Consolidate the content (ideally by defining what is considered Basic or Advanced) into a single page for each feature.

netlify[bot] commented 2 weeks ago

Deploy Preview for gokarna-hugo ready!

Name Link
Latest commit fad063bd79db8039e9e98324a5295efc21e7dddd
Latest deploy log https://app.netlify.com/sites/gokarna-hugo/deploys/670d393f621dc800086013f4
Deploy Preview https://deploy-preview-243--gokarna-hugo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jamesericdavidson commented 2 weeks ago

@526avijitgupta @yashmehrotra

Should we propose criteria for what should(n't) be considered Basic or Advanced?

2. Basics and Advanced occasionally cannibalise each other's features with little additional content, context, or links provided for further reading

Consolidate the content (ideally by defining what is considered Basic or Advanced) into a single page for each feature.

NACK. Will consider this for a future PR.

jamesericdavidson commented 2 weeks ago

@yashmehrotra @526avijitgupta

This is my opinionated update to the Basics docs to make it more concise, and suitable for newbies.

I welcome you to read the Summary and preview the changes.

Please note:

I look forward to your review!

P.S. As mentioned above, only the commits marked docs: are of interest.

yashmehrotra commented 2 weeks ago

Thanks for the mega update @jamesericdavidson

yashmehrotra commented 1 week ago

Sorry for the delay, will review and merge by weekend

@526avijitgupta Can you have a look too ?

526avijitgupta commented 1 week ago

I'll also review in the next couple of days. Thanks @yashmehrotra @jamesericdavidson

yashmehrotra commented 5 days ago

LGTM

Amazing work @jamesericdavidson

@526avijitgupta can we merge this ?