Closed jamesericdavidson closed 1 month ago
Name | Link |
---|---|
Latest commit | fad063bd79db8039e9e98324a5295efc21e7dddd |
Latest deploy log | https://app.netlify.com/sites/gokarna-hugo/deploys/670d393f621dc800086013f4 |
Deploy Preview | https://deploy-preview-243--gokarna-hugo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@526avijitgupta @yashmehrotra
Should we propose criteria for what should(n't) be considered Basic or Advanced?
2. Basics and Advanced occasionally cannibalise each other's features with little additional content, context, or links provided for further reading
Consolidate the content (ideally by defining what is considered Basic or Advanced) into a single page for each feature.
NACK. Will consider this for a future PR.
@yashmehrotra @526avijitgupta
This is my opinionated update to the Basics docs to make it more concise, and suitable for newbies.
I welcome you to read the Summary and preview the changes.
Please note:
exampleSite
's config.toml
was updated only to sort the parameters alphabetically (in congruity with the updates made to Basics!)exampleSite/public/
was added to .gitignore
because it's been driving me crazy for several PRs - this should be a welcome addition for any contributor :wink: I look forward to your review!
P.S. As mentioned above, only the commits marked docs:
are of interest.
Thanks for the mega update @jamesericdavidson
Sorry for the delay, will review and merge by weekend
@526avijitgupta Can you have a look too ?
I'll also review in the next couple of days. Thanks @yashmehrotra @jamesericdavidson
LGTM
Amazing work @jamesericdavidson
@526avijitgupta can we merge this ?
Summary
This PR aims to:
Fix any errors in the text, hyperlinks, etc.
Make text concise, while ensuring the documentation is appropriate for first-time Hugo users
Existing users can skip over the text, and don't need unmodified concepts re-introduced to them.
Distinguish between standard Hugo concepts (which Gokarna implements), and bespoke Gokarna features which do not follow Hugo standards
Work applies to Theme Documentation - Basics only. Advanced is unaffected, though Basics will continue linking to Advanced when appropriate.
N.B. Meaningful content changes are denoted in commits with the
docs:
message prefix.To Do
config.toml
{#my-heading}
where appropriate (e.g. b. Install the Theme)exampleSite/public/
when building withhugo serve
(useful for anyone working on upstream Gokarna, or forks!)toggleNext
must be a string (cannot eval true/false as bool)description
's function as ameta description
clearer for non-post content:config.toml
uses Gokarna's default values, whileparam
-specific documentation usesexampleSite
'sconfig.toml
params
/subheadings alphabeticallybackToTop
is not seen on mobile (does CSS define px? Min screen size - laptop, tablet?)There will be breakage if #243 is merged before #241 or #242 (and vice versa!)Removed
First pass of AdvancedDelay work to separate PRAdvanced: Re-order custom HTML subheadingsDelay work to separate PRHome page content is replicated in AdvancedDelay work to separate PRIssue 1 overhaulConsider for PR after AdvancedIssue 2 overhaulConsider for PR after AdvancedWeight is replicated in the Advanced section ?Delay work to separate PRInclude prev-next warningDelay work to separate PRCreate Your First Post: Mention archetype first (doc duplication?), then propose manual YAML insertion forEvery user will have access to archetypes, this is unnecessary to document in Gokarnapost
kindWhen using archetype: Link to Table of Contents, and mention setting toThis is already covered in advanced and shouldn't be replicated?true
if wantedExplain how(already included in #241 docs)title
is derived from file nameDescription:We don't recommend using front matter inindex.md
?index
Always identify Hugo standard features vs. bespoke Gokarna featuresDone implicitlyfeat: mention installing Hugo (not just Gokarna)not relevantfeat: link to markdown guidenot relevantMakenot suitable for Basicsdescription
's function as ameta description
clearer for non-post content: PagesExpand accentColor's role, as per MDN https://developer.mozilla.org/en-US/docs/Web/CSS/accent-colorunnecessaryIssues (for later PRs)
Comments are often replicated between Basic Configuration, Configuration and individual params with little additional content, context, or links provided for further reading
DRY. Only expand on the param if beneficial to the user, otherwise remove other instances of that feature's documentation (e.g. if the short comment in Basic Configuration is enough, only keep that instance).
Basics and Advanced occasionally cannibalise each other's features with little additional content, context, or links provided for further reading
Consolidate the content (ideally by defining what is considered Basic or Advanced) into a single page for each feature.