gokarna-theme / gokarna-hugo

A minimal opinionated theme for Hugo
https://gokarna-hugo.netlify.app
GNU General Public License v3.0
357 stars 139 forks source link

fix: Relative links for non-root hosting #249

Closed pkierski closed 1 week ago

pkierski commented 2 weeks ago

Fix for some links in case of hosting page from non-root path like https://example.com/blog

netlify[bot] commented 2 weeks ago

Deploy Preview for gokarna-hugo ready!

Name Link
Latest commit 2dfc2eeed32e60880639c5b236fdc5d78a59291f
Latest deploy log https://app.netlify.com/sites/gokarna-hugo/deploys/6704cc8ad878860008d3f9f3
Deploy Preview https://deploy-preview-249--gokarna-hugo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jamesericdavidson commented 2 weeks ago

Like a boss @pkierski 💪

This should solve #237

pkierski commented 2 weeks ago

This should solve #237

I'm afraid it isn't. It requires something like <link rel="shortcut icon" href="../favicon.ico"> in header.

There also one more similar issue: fonts in CSS. But I'm not sure if Hugo allows to make templates for CSS. Not so clean but working hack (I hope): to embed font urls in header (head.html).

yashmehrotra commented 1 week ago

Thanks for the PR @pkierski