Closed alanmcruickshank closed 1 day ago
Name | Link |
---|---|
Latest commit | f476d8b421d4ae1e110cc0ba32d497b0dff69579 |
Latest deploy log | https://app.netlify.com/sites/gokarna-hugo/deploys/6710d51bd755830008ecc5c8 |
Deploy Preview | https://deploy-preview-256--gokarna-hugo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Confirmed that social icons are working in the deploy preview: https://deploy-preview-256--gokarna-hugo.netlify.app/
Looks a good fix. We're generally speaking trying to undo some hard coding in the repo (#237). Hope this gets merged!
Regards,
James Davidson
-------- Original Message -------- On 17/10/2024 10:15, Alan Cruickshank wrote:
Confirmed that social icons are working in the deploy preview: https://deploy-preview-256--gokarna-hugo.netlify.app/
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>
Looks good for me. Indeed relUrl
is more generic for this than absUrl
.
lgtm thanks @alanmcruickshank 🙌
This resolves #255, and builds on #249. #249 fixed non-root hosting (#237), but broke alternate-domain hosting. I believe moving from
absUrl
torelUrl
solves both issues (including making sure the social icons work on the Netlify deploy previews for this repo!).Would appreciate review from @pkierski as author of #249.