gokarna-theme / gokarna-hugo

A minimal opinionated theme for Hugo
https://gokarna-hugo.netlify.app
GNU General Public License v3.0
378 stars 146 forks source link

enhancement: update screenshots #258

Closed jamesericdavidson closed 1 month ago

jamesericdavidson commented 1 month ago

README screenshots are out of date:

Low priority and good first issue.

526avijitgupta commented 1 month ago

This has been pending for a long time, thanks @jamesericdavidson

We already have a screenshots.py script for this purpose. I had tried running it a few weeks back but there were some errors.
Ideally, whoever picks this up should update the screenshot.py script and use that to generate the updated screenshots. cc @yashmehrotra

jamesericdavidson commented 1 month ago

Fixed in #262. Local run:

python screenshot.py 
Saved /
Saved /posts/
Saved /posts/theme-documentation-basics/
Created merged image for hugo showcase

git status
On branch feat/screenshot-container
Your branch is up to date with 'origin/feat/screenshot-container'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   images/screenshot-dark-home.png
    modified:   images/screenshot-dark-list.png
    modified:   images/screenshot-dark-post.png
    modified:   images/screenshot-light-home.png
    modified:   images/screenshot-light-list.png
    modified:   images/screenshot-light-post.png
    modified:   images/screenshot.png
    modified:   images/tn.png
jamesericdavidson commented 1 month ago

@526avijitgupta I think we should combine this with #184, and approach this in a cloud-native fashion: see #262.

jamesericdavidson commented 1 month ago

Narrowing the scope of this issue down - #263 will close this.

Will be tracking #262 and #184 separately, keeping the Containerfile and screenshot.py fixes together for portability.