search

gokayfem / ComfyUI_VLM_nodes

Custom ComfyUI nodes for Vision Language Models, Large Language Models, Image to Music, Text to Music, Consistent and Random Creative Prompt Generation
Apache License 2.0
297 stars 23 forks source link

Is it possible to combine both branches (main + mac) into the one? #92

Open bigcat88 opened 1 month ago

bigcat88 commented 1 month ago

This would greatly simplify the use of these wonderful Nodes.

Whether a node is running on a Mac or not is very easy to determine. Whether the Python package for AMD is installed is also a 2-line check.

Or is I missing something obvious?

gokayfem commented 1 month ago

autogptq library is not working on mac devices which internlm model was requires it thats why i seperated them. also there was a problem about the pycpuinfo package that needs a lower version for windows and linux to load faster and newer version for mac. i can delete the internlm node and autogptq dependency, since there are a lot of vlm models released after that model. we can combine them i think.

bigcat88 commented 1 month ago

also there was a problem about the pycpuinfo package that needs a lower version for windows and linux to load faster and newer version for mac.

this can be done in the requirements.txt (specify separate versions of pycpuinfo for Mac and linux, i mean)

i can delete the internlm node and autogptq dependency, since there are a lot of vlm models released after that model. we can combine them i think.

that will be awesome, as there are not so much working local vlm nodes except these repo :)