search

gokberkbar / locale_plus

LocalePlus allows easy access to native device locale data in Flutter apps. Includes language, country code, time zone, and number formatting preferences.
https://pub.dev/packages/locale_plus
MIT License
26 stars 10 forks source link

add support for samsung keyboards #2

Closed BentEngbers closed 1 year ago

BentEngbers commented 1 year ago

We could also create an edge case for samsung keyboards. Samsung keyboards on android (from what i understand) do not support , as an decimal separator. This seems to be a long standing issue. Perhaps we could adjust our decimal separator based on the keyboard used by the user. Or we could expose a new function called isUsingSamsungKeyboard to expose an api that shows if the user is using a samsung keyboard. I have found this relevant stackoverflow answer with some useful code.

gokberkbar commented 1 year ago

I will try to reproduce this issue and see what we can do. I will give updates accordingly. @BentEngbers

gokberkbar commented 1 year ago

I reproduced the issue and I think exposing new function called isUsingSamsungKeyboard is a better way to solve the issue. Because overriding it can be a problem for apps that only displays data but not taking input. We can add this feature to the next version scope. @BentEngbers