MahouShoujoMivutilde
commented
2 years ago I agree.
Also, I would like to add that while it is possible to implement on the user side (by redefining paste function in lfrc, as shown in man page), you'll loose the benefit of progress reporting in status bar and handling of duplicate names (.~1~ suffix).
Old buggy code
My very crude implementation: ```sh cmd paste &{{ set -- $(cat ~/.local/share/lf/files) mode="$1" shift case "$mode" in copy) # FIXME this does not work for directories if cp -rn --reflink=always -- "$@" .; then lf -remote "send $id echo reflinked!" else # copy lefts empty file on reflink fail if [ "$PWD/$(basename "$@")" != "$@" ]; then # OCD lmao rm -rf "$PWD/$(basename "$@")" fi lf -remote "send $id paste" fi ;; move) mv -n -- "$@" . # FIXME # unlike with copy, normal paste doesn't work here for some reason # i must be missing something # lf -remote "send $id paste" ;; esac rm ~/.local/share/lf/files lf -remote "send clear" }} ``` Maybe someone can come up with something more robust and better, but overall - i think this should be native feature, CoW fss has been around for a long time, it would be nice to take advantage of their features in more software.UPD Nov 12 2021
I've made a much better workaround. @jantatje, you might find it useful.
Old, but better code
Previous implementation above had a number of problems, but this one: 1. Tries to use CoW on btrfs 2. Falls back to lf's native paste if it can't 3. Handles matching names in destination with `.~1~` like lf 4. Forwards cp errors to status line, if any 5. No `rm` anywhere for a peace of mind ```bash cmd paste_try_cow &{{ # # This was very helpful for debugging: # log_file="$HOME/lf-reflink-log-$(date +'%Y-%m-%d_%H-%M-%S')" # [ -f "$log_file" ] || touch "$log_file" # exec 1>> $log_file 2>&1 # set -x # In theory, this may fail, # but I tested it on selection with 10k files - everything worked (bash) set -- $(cat ~/.local/share/lf/files) mode="$1" shift if [ $mode = 'copy' ]; then # Reflink if first item of selection and the destination are on the # same mount point and it is btrfs. # (to make sure reflink never fails in first place, so we don't have to # clean up) if [ "$(df "$PWD" --output=target | tail -n 1)" = \ "$(df "$@" --output=target | tail -n 1)" ] && \ [ "$(df --output=fstype "$PWD" | tail -n 1)" = btrfs ]; then echo 'selected copy and cp reflink paste' # # Handle same names in dst # # TODO make this run in parallel, idk # This is simple, but slow for i in "$@"; do name="${i##*/}" original="$name" count=0 while [ -w "$PWD/$name" ]; do count=$((count+1)) name="$original.~$count~" done set +e cp_out="$(cp -rn --reflink=always -- "$i" "$PWD/$name" 2>&1)" set -e if [ ! -z "$cp_out" ]; then lf -remote "send $id echoerr $cp_out" exit 0 fi done # Or just skip a file when names are the same. # (A LOT faster if you e.g. pasting selection of 10k files) # cp -rn --reflink=always -- "$@" . lf -remote "send clear" lf -remote "send $id echo reflinked!" else echo 'selected copy and lf native paste' lf -remote "send $id paste" fi elif [ $mode = 'move' ]; then echo 'selected move and lf native paste' lf -remote "send $id paste" fi # # for debug # set +x lf -remote "send load" }} # name is different to avoid recursive calls map p paste_try_cow ```UPD 3 Dec 2021
Added some cosmetic changes.
Latest version lives now in Wiki/Tips section. Apparently gone??
UPD 9 Oct 2024
❗Latest version❗
This snippet: 1. Tries to use CoW (reflinks) on btrfs, zfs and xfs 2. Falls back to lf's native paste **(keeps progress %)** if it can't 3. Handles matching names in destination with `.~1~` like lf 4. Forwards cp errors to status line, if any ...Now supports reflinks between subvolumes on same source drive. (Read before using) ```sh cmd paste_try_cow &{{ # # This was very helpful for debugging: # log_file="/tmp/lf-$id-paste_try_cow-log-$(date +'%Y-%m-%d_%H-%M-%S')" # [ -f "$log_file" ] || touch "$log_file" # exec 1>> $log_file 2>&1 # set -x # In theory, this may fail, # but I tested it on selection with 10k files - everything worked (bash) set -- $(cat ~/.local/share/lf/files) mode="$1" shift if [ $mode = 'copy' ]; then # Reflink if all items of selection and the destination are on the # same source device and it is CoW fs. # (to make sure reflink never fails in first place, so we don't have to # clean up) # Now with reflink support between different subvolumes of the same btrfs # Findmnt can only query one target at a time. # Thus, complex cases (e.g. one source item on btrfs on /dev/sdb1, # another source item on ext4 on /dev/sdb2) are not supported, # and will fallback to lf's paste. single_src=false if [[ "$(df --output=target -- "$@" | sed '1d' | sort -u | wc -l)" == 1 ]]; then single_src=true fi # We want: same device for all srcs and dst, with fs that support reflinks if [[ "$(findmnt --noheadings --list --nofsroot --real -o source --target "$PWD")" == \ "$(findmnt --noheadings --list --nofsroot --real -o source --target "$1")" ]] && \ $single_src && \ [[ "$(findmnt --noheadings --list --nofsroot --real -o fstype --target "$PWD")" =~ ^(btrfs|xfs|zfs)$ ]]; then echo 'selected copy and cp reflink paste' start=$(date '+%s') # Handle same names in dst # TODO: parallelism, idk - but exit/return/break won't stop the loop from subshell... for i in "$@"; do name="${i##*/}" original="$name" count=0 while [ -w "$PWD/$name" ]; do count=$((count+1)) name="$original.~$count~" done set +e cp_out="$(cp -rn --preserve=all --reflink=always -- "$i" "$PWD/$name" 2>&1)" set -e if [ ! -z "$cp_out" ]; then lf -remote "send $id echoerr $cp_out" exit 0 fi done finish=$(( $(date '+%s') - $start )) t='' if (( $finish > 2 )); then t="${finish}s" fi # Or just skip a file when names are the same. # (A LOT faster if you e.g. pasting selection of 10k files) # cp -rn --reflink=always -- "$@" . # lf -remote "send clear" green=$'\u001b[32m' reset=$'\u001b[0m' lf -remote "send $id echo ${green}reflinked!${reset} $t" else echo 'selected copy and lf native paste' lf -remote "send $id paste" # lf -remote "send clear" fi elif [ $mode = 'move' ]; then echo 'selected move and lf native paste' lf -remote "send $id paste" # lf -remote "send clear" fi # # for debug # set +x lf -remote "send load" }} # name is different to avoid recursive calls map p paste_try_cow ```
gokcehan
neeshy
It would be nice to have an option to enable CoW for copy operations, as of version 9.0 cp from GNU coreutils does this by default. Reflinking both saves space and makes copying on the same filesystem faster. There should be an option to turn this on or off, if enabled lf should first try to reflink the file and if that fails fall back to copying normally. In my opinion it makes most sense to default this setting to true.