Fix some issues found by lint

gokrazy / rsync

gokrazy rsync

BSD 3-Clause "New" or "Revised" License

494 stars 28 forks source link

Fix some issues found by lint #16

Closed joonas-fi closed 2 years ago

joonas-fi commented 2 years ago

Issue: #10

I fixed only what I think are "uncontroversial", i.e. I didn't yet mark any "lint ignore" annotations for more aggressive/"controversial" linters, because we don't yet have any agreed-on linter configuration.

Each commit explains what I fixed.

If you prefer, I can squash the commits before merging.

joonas-fi commented 2 years ago

Oh sorry, I I just now noticed that you wrote:

The unused and predeclared are too aggressive, I think.

I fixed some of them 🤦 I'll of course revert anything that you think is not worth the trouble.